linux-kernel - Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45B43093.6060500@bellsouth.net>
Date:	Sun, 21 Jan 2007 21:33:39 -0600
From:	Jay Cliburn <jacliburn@...lsouth.net>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	jeff@...zik.org, shemminger@...l.org, csnook@...hat.com,
	hch@...radead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, atl1-devel@...ts.sourceforge.net,
	kronos.it@...il.com
Subject: Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

Randy Dunlap wrote:
> On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote:
[snip]

>> +	value = ioread16(hw->hw_addr + REG_PCIE_CAP_LIST);
>> +	return ((value & 0xFF00) == 0x6C00) ? 0 : 1;
> 
> Are there defines or enums for these?
> Fewer magic numbers would be nice/helpful/readable.
[snip]
>> +	s32 ret;
>> +	ret = atl1_write_phy_reg(hw, 29, 0x0029);
> 
> Fewer magic numbers?

Unfortunately, we don't have a spec.  This is how the vendor coded it.

[snip]
>> +
>> +int enable_msi;
>> +module_param(enable_msi, int, 0444);
>> +MODULE_PARM_DESC(enable_msi, "Enable PCI MSI");
> 
> Hm, I thought that we didn't want individual drivers having MSI config
> options...

Luca?  This one was yours IIRC.  Care to chime in?

Randy, thank you for the review.

Jay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/