linux-kernel - Re: [v4l-dvb-maintainer] [PATCH] Register the bus, vendor and product IDs for dvb-usb remote device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45B3BB26.7000208@linuxtv.org>
Date:	Sun, 21 Jan 2007 14:12:38 -0500
From:	Michael Krufky <mkrufky@...uxtv.org>
To:	Chris Rankin <rankincj@...oo.com>
CC:	v4l-dvb-maintainer@...uxtv.org, linux-dvb@...uxtv.org,
	linux-kernel@...r.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] Register the bus,	vendor and product
 IDs for dvb-usb remote device

Chris Rankin wrote:
> Hi,
>
> This patch writes the USB vendor and product IDs into the /sys/class/input/inputX/id/ files, so
> that udev can find them. A rule like this does the trick for me:
>
> KERNEL="event*", SYSFS{../id/vendor}=="2040", SYSFS{../id/product}=="9301",
> SYMLINK+="input/dvb-remote"
>
> --- linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c.old 2007-01-21 02:43:11.000000000
> +0000
> +++ linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c     2007-01-21 02:39:02.000000000
> +0000
> @@ -107,6 +107,9 @@
>         d->rc_input_dev->keycodemax = KEY_MAX;
>         d->rc_input_dev->name = "IR-receiver inside an USB DVB receiver";
>         d->rc_input_dev->phys = d->rc_phys;
> +       d->rc_input_dev->id.bustype = BUS_USB;
> +       d->rc_input_dev->id.vendor = d->udev->descriptor.idVendor;
> +       d->rc_input_dev->id.product = d->udev->descriptor.idProduct;
>
>         /* set the bits for the keys */
>         deb_rc("key map size: %d\n", d->props.rc_key_map_size);

Chris,

The patch is fine.  Could you please provide a sign-off, in the form:

Signed-off-by: Your Name <email@...re.ss>

...so that we can apply this to the kernel sources?

Cheers,

Mike Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/