linux-kernel - Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45B495F9.4@yahoo.com.au>
Date:	Mon, 22 Jan 2007 21:46:17 +1100
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
CC:	Nicholas Miell <nmiell@...cast.net>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, linville@...driver.com
Subject: Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.

Robert P. J. Day wrote:

> by adding (temporarily) the definitions of TRUE and FALSE to types.h,
> you should then (theoretically) be able to delete over 100 instances
> of those same macros being *defined* throughout the source tree.
> you're not going to be deleting the hundreds and hundreds of *uses* of
> TRUE and FALSE (not yet, anyway) but, at the very least, by adding two
> lines to types.h, you can delete all those redundant *definitions* and
> make sure that nothing breaks.  (it shouldn't, of course, but it's
> always nice to be sure.)

Doesn't seem very worthwhile, and it legitimises this definition we're
trying to get rid of.

> *now*, once that's done, you can start going through the tree and
> doing the conversion from upper case to lower case, little by little,
> subsystem by subsystem.

I don't see why your patch is needed before the individual conversions?

> the predictable response will be, "you really should do that all at
> once."

You don't need to do it all at once.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/