linux-kernel - [PATCH] 9p: null terminate error strings for debug print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 22 Jan 2007 19:36:33 -0600
From:	Eric Van Hensbergen <ericvh@...il.com>
To:	akpm@...l.org
Cc:	linux-kernel@...r.kernel.org, v9fs-developer@...ts.sourceforge.net,
	Eric Van Hensbergen <ericvh@...ongmad.texas.9grid.us>,
	Eric Van Hensbergen <ericvh@...il.com>
Subject: [PATCH] 9p: null terminate error strings for debug print

From: Eric Van Hensbergen <ericvh@...ongmad.texas.9grid.us> - unquoted

We weren't properly NULL terminating protocol error strings for our
debug printk resulting in garbage being included in the output when debug
was enabled.

Signed-off-by: Eric Van Hensbergen <ericvh@...il.com>
---
 fs/9p/error.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/9p/error.c b/fs/9p/error.c
index ae91555..0d7fa4e 100644
--- a/fs/9p/error.c
+++ b/fs/9p/error.c
@@ -83,6 +83,7 @@ int v9fs_errstr2errno(char *errstr, int len)
 
 	if (errno == 0) {
 		/* TODO: if error isn't found, add it dynamically */
+		errstr[len] = 0;
 		printk(KERN_ERR "%s: errstr :%s: not found\n", __FUNCTION__,
 		       errstr);
 		errno = 1;
-- 
1.5.0.rc1.gde38

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/