linux-kernel - Re: [patch 00/46] High resolution timer / dynamic tick update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070124110415.GA2339@elte.hu>
Date:	Wed, 24 Jan 2007 12:04:15 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <johnstul@...ibm.com>,
	Arjan van de Veen <arjan@...radead.org>,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: [patch 00/46] High resolution timer / dynamic tick update


* Daniel Walker <dwalker@...sta.com> wrote:

> > > > > If stability is a question, -rt10 does currently compile for 
> > > > > my test config, due to this new HRT introduction. [...]
[...]

NOTE: the build problem you have is -rt specific. In any case it is not 
due to this new HRT introduction but due to another, -rt only feature or 
high-res timers: the ability to asynchronously wait on their completion 
without polling. But that does not matter to -mm kernels.

I have put your .config into the new -mm queue Thomas submitted and it 
compiled and booted just fine.

> > > No, the test config I was talking about is SMP i386 (which is what 
> > > I usually use). [...]
> > 
> > then please send me the .config.
> 
> Sure.

please check whether the patch below (ontop of -rt10) fixes this for 
you.

	Ingo

Index: linux/kernel/hrtimer.c
===================================================================
--- linux.orig/kernel/hrtimer.c
+++ linux/kernel/hrtimer.c
@@ -992,8 +994,6 @@ int hrtimer_get_res(const clockid_t whic
 }
 EXPORT_SYMBOL_GPL(hrtimer_get_res);
 
-#ifdef CONFIG_HIGH_RES_TIMERS
-
 #ifdef CONFIG_PREEMPT_SOFTIRQS
 # define wake_up_timer_waiters(b)	wake_up(&(b)->wait)
 
@@ -1020,6 +1020,8 @@ void hrtimer_wait_for_timer(const struct
 # define wake_up_timer_waiters(b)	do { } while (0)
 #endif
 
+#ifdef CONFIG_HIGH_RES_TIMERS
+
 /*
  * High resolution timer interrupt
  * Called with interrupts disabled
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/