linux-kernel - Re: [PATCH] gpu/radeonfb: add GPU support to radeonfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Jan 2007 08:54:08 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Roger While <simrw@...-basis.de>
Cc:	linux-kernel@...r.kernel.org, airlied@...ux.ie
Subject: Re: [PATCH] gpu/radeonfb: add GPU support to radeonfb

On Wed, 2007-01-24 at 17:30 +0100, Roger While wrote:
> @@ -241,9 +241,9 @@ void radeonfb_engine_reset(struct radeon
>   	INREG(HOST_PATH_CNTL);
>   	OUTREG(HOST_PATH_CNTL, host_path_cntl);
> 
> -	if (rinfo->family != CHIP_FAMILY_R300 ||
> -	    rinfo->family != CHIP_FAMILY_R350 ||
> -	    rinfo->family != CHIP_FAMILY_RV350)
> +	if (rinfo->gpu_info->family != CHIP_FAMILY_R300 ||
> +	    rinfo->gpu_info->family != CHIP_FAMILY_R350 ||
> +	    rinfo->gpu_info->family != CHIP_FAMILY_RV350)
>   		OUTREG(RBBM_SOFT_RESET, rbbm_soft_reset);
> 
> Alarm bells going off - "!=" combined with "||" ?
> Looks like a reset will always be done.

Wow, good catch ! That's a bug that has been in radeonfb pretty much for
ever ! Might have come from earlier versions of X before we had
IS_R300_VARIANT...

B

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/