linux-kernel - [-mm patch] MTD_CK804XROM must depend on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070124223600.GQ17836@stusta.de>
Date:	Wed, 24 Jan 2007 23:36:00 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Andrew Morton <akpm@...l.org>, Ryan Jackson <rjackson@...i.com>,
	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-kernel@...r.kernel.org, dwmw2@...radead.org
Subject: [-mm patch] MTD_CK804XROM must depend on PCI

On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote:
>...
>  git-mtd.patch
>...
>  git trees

CONFIG_MTD_CK804XROM=y, CONFIG_PCI=n results in the following compile 
error:

<--  snip  -->

...
  CC      drivers/mtd/maps/ck804xrom.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/mtd/maps/ck804xrom.c: In function 'ck804xrom_init_one':
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/mtd/maps/ck804xrom.c:114: error: implicit declaration of function 'pci_dev_get'
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/mtd/maps/ck804xrom.c:114: warning: assignment makes pointer from integer without a cast
make[4]: *** [drivers/mtd/maps/ck804xrom.o] Error 1

<--  snip  -->

Considering what hardware this driver is driving, a dependency on PCI 
also seems logical.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

--- linux-2.6.20-rc4-mm1/drivers/mtd/maps/Kconfig.old	2007-01-24 13:53:18.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/mtd/maps/Kconfig	2007-01-24 13:53:39.000000000 +0100
@@ -204,7 +204,7 @@

 config MTD_CK804XROM
 	tristate "BIOS flash chip on Nvidia CK804"
-	depends on X86 && MTD_JEDECPROBE
+	depends on X86 && MTD_JEDECPROBE && PCI
 	help
 	  Support for treating the BIOS flash chip on nvidia motherboards
 	  as an MTD device - with this you can reprogram your BIOS.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/