linux-kernel - Re: [PATCH 2.6.20-rc5] Gigaset ISDN driver error handling fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070123224742.4b13b2ea.akpm@osdl.org>
Date:	Tue, 23 Jan 2007 22:47:42 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Tilman Schmidt <tilman@...p.cc>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Hansjoerg Lipp <hjlipp@....de>
Subject: Re: [PATCH 2.6.20-rc5] Gigaset ISDN driver error handling fixes

On Wed, 17 Jan 2007 18:42:13 +0100 (CET)
Tilman Schmidt <tilman@...p.cc> wrote:

> +	mutex_init(&cs->mutex);
> +	mutex_lock(&cs->mutex);

I have vague memories of making rude comments about this a few months ago.

It is very weird to lock a mutex just after intialising it.  I mean, if any other
thread can lock this mutex then there's a race.  If no other thread can
lock it, then this thread doesn't need to either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/