linux-kernel - Re: [PATCH] alsa: correct nonsensical sysfs device symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45B8942F.7050006@drzeus.cx>
Date:	Thu, 25 Jan 2007 12:27:43 +0100
From:	Pierre Ossman <drzeus@...eus.cx>
To:	"Christopher \"Monty\" Montgomery" <xiphmont@...il.com>
CC:	perex@...e.cz, greg@...ah.com, mclasen@...hat.com, jrb@...hat.com,
	Lennart Poettering <lennart@...ttering.net>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	fedora-desktop-list@...hat.com
Subject: Re: [PATCH] alsa: correct nonsensical sysfs device symlinks

Christopher "Monty" Montgomery wrote:
> This patch was generated against 2.6.20-rc5; it fixes a bug that
> cropped up in a late 2.6.19-mm kernel.
> 
> When ALSA's sysfs device creation was converted from using
> class_device_create() to device_create(), the fourth param from
> class_device_create() [dev] was simply plugged into arg 2 of
> device_create().  This causes the device symlinks under all the
> class/sound/[node] to point to nonsensical places.  Among other
> problems, this breaks HAL and all audio software that depends on HAL.
> 

There are no device symlinks anymore, so the current behaviour seems
correct. HAL should follow the symlink, then move up in the device tree
to find a suitable parent.

Rgds
Pierre



Download attachment "signature.asc" of type "application/pgp-signature" (252 bytes)