linux-kernel - [PATCH] alsa: correct nonsensical sysfs device symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <806dafc20701241750t53b86babn36831cadc7dfa76c@mail.gmail.com>
Date:	Wed, 24 Jan 2007 20:50:06 -0500
From:	"Christopher \"Monty\" Montgomery" <xiphmont@...il.com>
To:	perex@...e.cz, greg@...ah.com, mclasen@...hat.com, jrb@...hat.com,
	"Lennart Poettering" <lennart@...ttering.net>,
	"Pierre Ossman" <drzeus@...eus.cx>
Cc:	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	fedora-desktop-list@...hat.com
Subject: [PATCH] alsa: correct nonsensical sysfs device symlinks

This patch was generated against 2.6.20-rc5; it fixes a bug that
cropped up in a late 2.6.19-mm kernel.

When ALSA's sysfs device creation was converted from using
class_device_create() to device_create(), the fourth param from
class_device_create() [dev] was simply plugged into arg 2 of
device_create().  This causes the device symlinks under all the
class/sound/[node] to point to nonsensical places.  Among other
problems, this breaks HAL and all audio software that depends on HAL.

The nature of this bug is not simply a need to update HAL;
class/[node]/device symlinks are required to point to a device entry
in /sys/devices; the bug causes them to point to other places within
/sys/class.  This patch is [hopefully] a trivial change to restore the
desired behavior.

Signed-off-by: Monty Montgomery <xiphmont@...il.com>
---

Apologies for sending patch as text/plain attachment; we've
established in the past that Gmail will not leave unformatted text
email unmunged.

View attachment "alsa-sysfs-fix-2.6.20-rc5.txt" of type "text/plain" (674 bytes)