linux-kernel - [PATCH] md: Remove unnecessary printk when raid5 gets an unaligned read.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id:  <1070125050616.21497@suse.de>
Date:	Thu, 25 Jan 2007 16:06:16 +1100
From:	NeilBrown <neilb@...e.de>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] md: Remove unnecessary printk when raid5 gets an unaligned read.

One more... (sorry about the dribs-and-drabs approach)
NeilBrown

### Comments for Changeset

raid5_mergeable_bvec tries to ensure that raid5 never sees a read
request that does not fit within just one chunk.  However as we
must always accept a single-page read, that is not always possible.

So when "in_chunk_boundary" fails, it might be unusual, but it is not
a problem and printing a message every time is a bad idea.

Signed-off-by: Neil Brown <neilb@...e.de>

### Diffstat output
 ./drivers/md/raid5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c
--- .prev/drivers/md/raid5.c	2007-01-25 15:57:56.000000000 +1100
+++ ./drivers/md/raid5.c	2007-01-25 15:55:43.000000000 +1100
@@ -2630,7 +2630,7 @@ static int chunk_aligned_read(request_qu
 	mdk_rdev_t *rdev;

 	if (!in_chunk_boundary(mddev, raid_bio)) {
-		printk("chunk_aligned_read : non aligned\n");
+		PRINTK("chunk_aligned_read : non aligned\n");
 		return 0;
 	}
 	/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/