[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200701271125.33121.david-b@pacbell.net>
Date: Sat, 27 Jan 2007 11:25:32 -0800
From: David Brownell <david-b@...bell.net>
To: Hans-Peter Nilsson <hans-peter.nilsson@...s.com>
Cc: linux-kernel@...r.kernel.org, mikael.starvik@...s.com,
spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6
On Saturday 27 January 2007 2:11 am, Hans-Peter Nilsson wrote:
> > From: David Brownell <david-b@...bell.net>
> > Date: Fri, 26 Jan 2007 15:21:15 -0800
>
> > > > That flag could work in conjunction with a byte
> > >
> > > Or why not a 32-bit word!
> >
> > If a driver wants a repeating 32-bit pattern, they should just
> > provide a properly initialized tx buffer.
>
> I'm suggesting the default_tx_word be able to fill out "common"
> values of bits_per_word when > 8, else it'd be useless as a
> 1-filler for larger sizes than byte. Making it a single bit
> then wouldn't cater to your debug-with-scope use-case.
That wasn't my idea, it was borrowed from someone else's debug
arsenal. ;)
In any case, I think that sort of debug assist doesn't need to
stay in production system. See the patch I posted previously...
- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists