linux-kernel - Re: + dynamic-kernel-command-line-sparc64-fix.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e0cf0bf0701270314t3369dc7fke7fe8589be1d5bd7@mail.gmail.com>
Date:	Sat, 27 Jan 2007 13:14:57 +0200
From:	"Alon Bar-Lev" <alon.barlev@...il.com>
To:	"akpm@...l.org" <akpm@...l.org>
Cc:	mm-commits@...r.kernel.org, davem@...emloft.net,
	"kernel list" <linux-kernel@...r.kernel.org>
Subject: Re: + dynamic-kernel-command-line-sparc64-fix.patch added to -mm tree

On 1/27/07, akpm@...l.org <akpm@...l.org> wrote:
> diff -puN drivers/sbus/char/openprom.c~dynamic-kernel-command-line-sparc64-fix drivers/sbus/char/openprom.c
> --- a/drivers/sbus/char/openprom.c~dynamic-kernel-command-line-sparc64-fix
> +++ a/drivers/sbus/char/openprom.c
> @@ -283,7 +283,7 @@ static int oprompath2node(void __user *a
>
>  static int opromgetbootargs(void __user *argp, struct openpromio *op, int bufsize)
>  {
> -       char *buf = saved_command_line;
> +       char *buf = boot_command_line;
>         int len = strlen(buf);
>
>         if (len > bufsize)

Hello Andrew,

I don't think this is correct.
The boot_command_line should only be used by init code.
Drivers should continue to use saved_command_line.

I don't know why saved_command_line cannot be resolved and
boot_command_line can be.
They are both located in linux/init.h

extern char __initdata boot_command_line[];
extern char *saved_command_line;

And the drivers/sbus/char/openprom.c do include it and I assume
__ASSEMBLY__ is not defined.

Best Regards,
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/