linux-kernel - Re: [PATCH 2/8] readahead: state based method routines: explicitly embed class_new/class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1HAmF2-0000cV-Ux@be1.lrz>
Date:	Sat, 27 Jan 2007 13:01:08 +0100
From:	Bodo Eggert <7eggert@....de>
To:	Fengguang Wu <wfg@...l.ustc.edu.cn>, Andrew Morton <akpm@...l.org>,
	Martin Peschke <mp3@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] readahead: state based method routines: explicitly embed class_new/class_old inside flags

Fengguang Wu <wfg@...l.ustc.edu.cn> wrote:

> The new/old ra class were implicitly stored in low bits of
> file_ra_state.flags. Now make the data structure obvious, and remove the
> coding tricks.

> +++ linux-2.6.20-rc4-mm1/include/linux/fs.h

> -     unsigned long flags;    /* RA_FLAG_xxx | ra_class_old | ra_class_new */
> +     union {
> +             unsigned long   flags;  /* RA_FLAG_xxx | class_old | class_new */
> +             struct {
> +                     u8      class_new;
> +                     u8      class_old;

This doesn't work on big endiam machines, does it?

IMO you should use a bitfield instead.
-- 
Your e-mail has been returned due to insufficient voltage. 

Friß, Spammer: aegzcH4Js@...vh-7.7eggert.dyndns.org
 ptulV7@...eggert.dyndns.org vkIfyB@...ltba.7eggert.dyndns.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/