linux-kernel - Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82e4877d0701281444h333c581fr66d60cca9d03749d@mail.gmail.com>
Date:	Sun, 28 Jan 2007 17:44:26 -0500
From:	"Parag Warudkar" <parag.warudkar@...il.com>
To:	thunder7@...all.nl
Cc:	"akpm@...l.org" <akpm@...l.org>, ak@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages

On 1/28/07, Parag Warudkar <parag.warudkar@...il.com> wrote:
> >CONFIG_BINFMT_ELF=y
> ># CONFIG_BINFMT_MISC is not set
> ># CONFIG_IA32_EMULATION is not set
>
> Hm Ok. That's explainable. You don't have CONFIG_IA32_EMULATION set
> and arch_setup_additional pages is only defined/exported in
> syscall32.c which won't be built in your case. (It should go away if
> you set CONFIG_IA32_EMULATION).
>

I think the easy and correct fix for this situation is defining
CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if
IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to
require arch_setup_additional_pages() only IA32 emulation requires
it.)

The patch below should fix it. (Please use attachment - less chance of
whitespace issues. Sorry no control over mail client atm)

Signed-off-by: Parag Warudkar <parag.warudkar@...il.com>

--- linux-2.6.20-rc6-mm1/arch/x86_64/Kconfig.orig	2007-01-28
17:32:09.000000000 -0500
+++ linux-2.6.20-rc6-mm1/arch/x86_64/Kconfig	2007-01-28 17:32:48.000000000 -0500
@@ -405,7 +405,7 @@
 config ARCH_HAS_SETUP_ADDITIONAL_PAGES
 	bool
 	default y
-	depends on X86_64
+	depends on X86_64 && IA32_EMULATION

 config OUT_OF_LINE_PFN_TO_PAGE
 	def_bool y

View attachment "x86_64-Kconfig-fix-setup_additional_pages.patch" of type "text/x-patch" (351 bytes)