linux-kernel - Re: [PATCH] tty: cleanup release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070129120100.GA4338@devserv.devel.redhat.com>
Date:	Mon, 29 Jan 2007 07:01:00 -0500
From:	Alan Cox <alan@...hat.com>
To:	Christoph Hellwig <hch@....de>
Cc:	alan@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: cleanup release_mem

On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
> release_mem contains two copies of exactly the same code.  Refactor
> these into a new helper, release_tty.  The only change in behaviour
> is that the driver reference count is now decremented after the
> master tty has been freed instead of before.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Alan Cox <alan@...hat.com>

Please propogate the mutex_ FIXME comment to both functions as it may
well need to cover tty->link

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/