linux-kernel - Re: [PATCH] kprobes: Fix compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <112DEBE1-0765-40DC-B8FD-75DE7336312A@kernel.crashing.org>
Date:	Tue, 30 Jan 2007 01:12:17 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	ananth@...ibm.com,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	prasanna@...ibm.com, anil.s.keshavamurthy@...el.com,
	"David S. Miller" <davem@...emloft.net>,
	Paul Mackerras <paulus@...ba.org>,
	masami.hiramatsu.pt@...achi.com
Subject: Re: [PATCH] kprobes: Fix compiler warning


On Jan 30, 2007, at 1:05 AM, Kumar Gala wrote:

>
> On Jan 29, 2007, at 11:55 PM, Ananth N Mavinakayanahalli wrote:
>
>> On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote:
>>> On ppc the compiler gripes about:
>>>
>>> kernel/kprobes.c: In function 'collect_garbage_slots':
>>> kernel/kprobes.c:215: warning: comparison is always false due to  
>>> limited
>>> range of data type
>>>
>>> The compiler ends up optimizing away the test since char's are  
>>> unsigned on
>>> ppc.
>>
>> Kumar,
>>
>> Masami fixed this last week:
>>
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=116968723823366&w=2
>>
>> Patch currently in -mm.
>>
>> Thanks,
>> Ananth
>
> Cool, Masami's patch looks far more complete.

Andrew,

What are your thoughts on forward Masami patch to Linus for 2.6.20  
since it fixes a real bug on PPC?

- k
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/