[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1170143630.26655.326.camel@localhost.localdomain>
Date: Tue, 30 Jan 2007 18:53:50 +1100
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: cbe-oss-dev@...abs.org, maynardj@...ibm.com,
linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
oprofile-list@...ts.sourceforge.net
Subject: Re: [Cbe-oss-dev] [RFC, PATCH 4/4] Add support to OProfile for
profiling Cell BE SPUs -- update
> > +/* Defines used for sync_start */
> > +#define SKIP_GENERIC_SYNC 0
> > +#define SYNC_START_ERROR -1
> > +#define DO_GENERIC_SYNC 1
> > +
> > +typedef struct vma_map
> > +{
> > + struct vma_map *next;
> > + unsigned int vma;
> > + unsigned int size;
> > + unsigned int offset;
> > + unsigned int guard_ptr;
> > + unsigned int guard_val;
> > +} vma_map_t;
I haven't had time to look in details yet but in that context, what does
"vma" stands for ? There's already an important vm data structure in
linux routinely called "vma" and thus I suspect this is a poor naming
choice as it will cause confusion.
Cheers,
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists