linux-kernel - Re: 2.6.20-rc6-mm3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070130003257.1745273c.akpm@osdl.org>
Date:	Tue, 30 Jan 2007 00:32:57 -0800
From:	Andrew Morton <akpm@...l.org>
To:	"Sunil Naidu" <akula2.shark@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: 2.6.20-rc6-mm3

On Tue, 30 Jan 2007 13:46:54 +0530
"Sunil Naidu" <akula2.shark@...il.com> wrote:

> On 1/30/07, Andrew Morton <akpm@...l.org> wrote:
> >
> > - If you hit a bug in -mm and it is not obvious which patch caused it, it is
> >   most valuable if you can perform a bisection search to identify which patch
> >   introduced the bug.  Instructions for this process are at
> 
> I am hit with a compile error! Here is the info:-
> 
>   CC [M]  drivers/net/chelsio/cxgb2.o
>   CC [M]  drivers/net/chelsio/espi.o
>   CC [M]  drivers/net/chelsio/tp.o
>   CC [M]  drivers/net/chelsio/pm3393.o
>   CC [M]  drivers/net/chelsio/sge.o
> drivers/net/chelsio/sge.c: In function 't1_interrupt':
> drivers/net/chelsio/sge.c:1705: error: expected ')' before 'work_done'
> drivers/net/chelsio/sge.c:1722: error: expected expression before '}' token
> drivers/net/chelsio/sge.c:1697: warning: unused variable 'work_done'
> drivers/net/chelsio/sge.c:1722: warning: no return statement in
> function returning non-void
> make[3]: *** [drivers/net/chelsio/sge.o] Error 1
> make[2]: *** [drivers/net/chelsio] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2

--- a/drivers/net/chelsio/sge.c~git-netdev-all-chelsio-fix
+++ a/drivers/net/chelsio/sge.c
@@ -1701,7 +1701,7 @@ irqreturn_t t1_interrupt(int irq, void *
 
 	writel(F_PL_INTR_SGE_DATA, adapter->regs + A_PL_CAUSE);
 
-	if (likely(responses_pending(adapter))
+	if (likely(responses_pending(adapter)))
 		work_done = process_responses(adapter, -1);
 	else
 		work_done = t1_slow_intr_handler(adapter);
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/