linux-kernel - Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070130094233.GA6972@infradead.org>
Date:	Tue, 30 Jan 2007 09:42:33 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Josef 'Jeff' Sipek <jsipek@...sunysb.edu>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

On Mon, Jan 29, 2007 at 03:37:42PM -0500, Josef 'Jeff' Sipek wrote:
> The only fields that we have to watch out for are the dentry and vfsmount.
> Additionally, this makes Unionfs gentler on the stack as nameidata is rather
> large.

That's onviously not true at all.  To handle any filesystems using intents
(e.g. NFSv4) you need to do much more.  Then again doing things correctly
doesn't seem to be interesting to the stackable filesystems crowd an this
problem has been constantly ignored over the last year, including merging
ecryptfs which has been broken in the same way.

Folks, if you want your stackable filesystem toys taken seriously you
need to fix these kind of issues instead of talking them away.  And yes,
this will involve some surgery to the VFS.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/