linux-kernel - Re: [PATCH] Add "is_power_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jan 2007 23:25:56 +1100
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
CC:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Paul Mackerras <paulus@...ba.org>, dhowells@...hat.com,
	galak@...nel.crashing.org
Subject: Re: [PATCH] Add "is_power_of_2" checking to log2.h.

Robert P. J. Day wrote:
>   Add the inline function "is_power_of_2()" to log2.h, where the value
> zero is *not* considered to be a power of two.

> 
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> 
>  /*
> + *  Determine whether some value is a power of two, where zero is
> + * *not* considered a power of two.
> + */

Why the qualifier? Zero *is* not a power of 2, is it?

> +
> +static inline __attribute__((const))
> +bool is_power_of_2(unsigned long n)
> +{
> +	return (n != 0 && ((n & (n - 1)) == 0));
> +}
> +
> +/*
>   * round up to nearest power of two
>   */
>  static inline __attribute__((const))


-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/