linux-kernel - Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200701300507.47068.arnd@arndb.de>
Date:	Tue, 30 Jan 2007 05:07:46 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	cbe-oss-dev@...abs.org, maynardj@...ibm.com
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	oprofile-list@...ts.sourceforge.net
Subject: Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

On Monday 29 January 2007 20:46, Maynard Johnson wrote:
>   This is a clean up patch that includes the following changes:
> 
>         -It removes some macro definitions that are only used once
>          with the actual code.
>         -Some comments were added to clarify the code based on feedback
>          from the community.
>         -The write_pm_cntrl() and set_count_mode() were passed a structure
>          element from a global variable.  The argument was removed so the
>          functions now just operate on the global directly.
>         -The set_pm_event() function call in the cell_virtual_cntr() routine
>          was moved to a for-loop before the for_each_cpu loop
> 
> Signed-off-by: Carl Love <carll@...ibm.com>
> Signed-off-by: Maynard Johnson <mpjohn@...ibm.com>
> 

Acked-by: Arnd Bergmann <arnd.bergmann@...ibm.com>

Just a small side note: Please give each of your patches a one-line
summary in the subject of the email. I'm filing this one under:
"cell: oprofile cleanup".

It would also be good if you could use a mailer that sends out
patches as inline, so you don't need to resort to using attachments.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/