linux-kernel - Re: [PATCH 12/23] clocksource: add clocksource_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070131114615.GB1847@elte.hu>
Date:	Wed, 31 Jan 2007 12:46:15 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, johnstul@...ibm.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 12/23] clocksource: add clocksource_get_clock()


* Daniel Walker <dwalker@...sta.com> wrote:

> One new API call clocksource_get_clock() which allows clocks to be 
> selected based on their name, or if the name is null the highest rated 
> clock is returned.

this one (and the dependent APIs utilizations) look a step in the right 
direction to me, but they are not fully consequent and thus a bit 
confusing at the moment:

- the current_clocksource is now something that is conceptually related 
  to timekeeping - while it still resides in the clocksource domain.

- if we do this split there should be a separate sysfs hierarchy for 
  timekeeping, separate of clocksource

- you use struct sys_device clocksource_sys_device from clocksource.c in 
  timekeeping.c, which is inconsistent as well.

so these bits need more work.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/