[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1170256065.9781.19.camel@imap.mvista.com>
Date: Wed, 31 Jan 2007 07:07:45 -0800
From: Daniel Walker <dwalker@...sta.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: akpm@...l.org, linux-kernel@...r.kernel.org, johnstul@...ibm.com,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 07/23] clocksource: rating sorted list
On Wed, 2007-01-31 at 10:34 +0100, Ingo Molnar wrote:
> a rating change can occur due to other things as well, not only due to
> 'tsc unstable' events. So keeping an API around that changes the rating
> (and propagates all related changes), makes more sense to me.
>
> also, a pure function call is the most natural (and most flexible) API,
> for a centrally registered resource like a clock source driver. And a
> rating change should imply a reselect too, obviously. That way we
> replace 2 lines with 1 line - that's a real API improvement and a real
> cleanup patch.
>
> and that's precisely what Thomas' patch in -mm that your queue undoes
> implements. (see: simplify-the-registration-of-clocksources.patch in
> -mm) Have you considered Thomas' change when you dropped it?
My patch set makes clocksource ratings constant (when fully applied).
That particular function is dropped all together .
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists