linux-kernel - Re: [PATCH 23/23] clocksource tsc: add verify routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070131173308.GG4468@elte.hu>
Date:	Wed, 31 Jan 2007 18:33:08 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, johnstul@...ibm.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 23/23] clocksource tsc: add verify routine


* Daniel Walker <dwalker@...sta.com> wrote:

> > firstly, it allows a circular verification dependency in 
> > highres+dyntick mode between the jiffies and tsc clocksources.
> 
> In the current implementation, it's only happens if the only clocks 
> that exist are "tsc" and "jiffies" which makes verification impossible 
> anyway .. It's unlikely, but it is possible , the fix is not that 
> complex.

yes, the fix is not that complex and it already exists: Thomas' 
clocksource-add-verification-watchdog-helper.patch. You said before that 
Thomas' code was unnecessarily generic, but your version contained at 
least one bug, despite having had review feedback about precisely that 
issue.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/