linux-kernel - Re: [PATCH 3/3] cxacru: Store all device status information and report it when atm_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Jan 2007 15:39:14 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Simon Arlott <e5d74fcd64729b17de1hc0yh0003aeoo@...nder.lp0.eu>
Cc:	Simon Arlott <simon@...ott.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] cxacru: Store all device status information and
 report it when atm_proc_read is called.

On Tue, 30 Jan 2007 21:30:29 +0000
Simon Arlott <simon@...ott.org> wrote:

> +static int cxacru_proc_read(struct usbatm_data *usbatm_instance,
> +	struct atm_dev *atm_dev, loff_t * pos, char *page)
> +{
> +	struct cxacru_data *instance = usbatm_instance->driver_data;
> +	u32 *cxinf = instance->cxinf_status;
> +	int left = *pos;
> +
> +	if (!left--)
> +		return sprintf(page, "# %s\n", usbatm_instance->description);
> +
> +	if (!left--) {
> +		if (cxinf[CXINF_LINE_STATUS] == 5) {
> +			return sprintf(page, "# UP %u/%u\n",
> +				cxinf[CXINF_DOWNSTREAM_RATE],
> +				cxinf[CXINF_UPSTREAM_RATE]);
> +		} else {
> +			return sprintf(page, "# DOWN\n");
> +		}
> +	}

hm, how well-tested was this proc interface?  The pread() and lseek()
behaviour might be strange.

I guess as long as it doesn't oops, hang or anything like that then it'll
be OK.  Anyone who does anything apart from a single big-fat-read from a 
procfile has a good chance of getting into trouble :(
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/