[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070131162631.4ae5800d.akpm@osdl.org>
Date: Wed, 31 Jan 2007 16:26:31 -0800
From: Andrew Morton <akpm@...l.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: PaweÅ Sikora <pluto@...k.net>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Christoph Hellwig <hch@....de>,
Pekka Enberg <penberg@...helsinki.fi>,
"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
Martin Peschke <mp3@...ibm.com>, Adrian Bunk <bunk@...sta.de>,
Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: Linux 2.6.20-rc7
On Wed, 31 Jan 2007 16:19:06 -0800 (PST)
Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> I should either revert that commit or just check for "free_pages" being
> negative. The latter, in many ways, is probably better, because generally
> we simply should never work with negative numbers in the kernel, so when
> something potentially goes negative, we're probably just better off always
> testing it explicitly anyway.
>
> Nick, Andrew, any preferences?
It would be cleaner to check for negativity, but note that we keep
subtracting stuff from free_pages in the later loop, so we'd need to check
there as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists