linux-kernel - Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1170342991.9781.189.camel@imap.mvista.com>
Date:	Thu, 01 Feb 2007 07:16:31 -0800
From:	Daniel Walker <dwalker@...sta.com>
To:	Miguel Ojeda <maxextreme@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1

On Thu, 2007-02-01 at 16:16 +0100, Miguel Ojeda wrote:
> The problem is easy:
> 
> ks0108_init() prints the error message and exit with -EINVAL, so the
> module isn't loaded properly.
> 
> However, cfag12864b_init() is called, although ks0108 failed. It
> returns 0 and after a while cfag12864b calls ks0108_writecontrol()
> which dereferences the uninitialized pointer ks0108_parport:
> 
> 	parport_write_control(ks0108_parport, byte ^ (bit(0) | bit(1) | bit(3)));
> 
> Why is cfag12864b_init() called if ks0108 module didn't load properly?
> Is that normal? If so, how a module should alarm other modules about
> it failed loading?

I don't know if this matters, but I had this driver built-in , and not a
module ..

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/