linux-kernel - [PATCH 0/10] fix usages of local_irq_save() and local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Feb 2007 16:35:35 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH 0/10] fix usages of local_irq_save() and local_irq_disable()

Hi,

the following series of 10 trivial patches contains two changes:

- removes local_irq_disable() on redundant places after local_irq_save()
- turns local_save_flags() + local_irq_disable() into local_irq_save()

It was quite surprising to find it on so many places. There is another gem 
in drivers/block/ataflop.c::do_fd_request():

        local_save_flags(flags);        /* The request function is called with ints
        local_irq_disable();             * disabled... so must save the IPL for later */

I am not sure if the author was aware of the fact that he commented also 
the local_irq_disable() call :) I will look into the code a bit more 
later, to see whether it just really wants to save flags, or this should 
be converted into standard local_irq_save(flags).

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/