linux-kernel - Re: [PATCH] CELL PPU Oprofile cleanup patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1170371752.5204.20.camel@dyn9047021078.beaverton.ibm.com>
Date:	Thu, 01 Feb 2007 15:15:52 -0800
From:	Carl Love <cel@...ibm.com>
To:	Michael Neuling <mikey@...ling.org>
Cc:	cbe-oss-dev@...abs.org, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CELL PPU Oprofile cleanup patch

Mikey:

Yes, that is an error.  Thanks for the catch.

          Carl Love

On Fri, 2007-02-02 at 09:52 +1100, Michael Neuling wrote:
> Carl,
> 
> > +#define NUM_TRACE_BUS_WORDS 4
> > +#define NUM_INPUT_BUS_WORDS 2
> 
> <snip>
> 
> > -     for (i = 0; i < 4; i++)
> > +     for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> >               trace_bus[i] = 0xff;
> >  
> > -     for (i = 0; i < 2; i++)
> > +     for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> >               input_bus[i] = 0xff;
> 
> The first loop looks like a bug...   Shouldn't it be
> NUM_TRACE_BUS_WORDS?
> 
> Mikey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/