linux-kernel - Re: Please revert "fix typo in geode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Feb 2007 09:40:20 +0100
From:	Juergen Beisert <juergen127@...uzholzen.de>
To:	linux-kernel@...r.kernel.org
Cc:	Adrian Bunk <bunk@...sta.de>, takada <takada@....nifty.com>,
	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	Jordan Crouse <jordan.crouse@....com>
Subject: Re: Please revert "fix typo in geode_configre()@cyrix.c"

On Friday 02 February 2007 07:29, Adrian Bunk wrote:
> Since there is AFAIK no actually observed problem fixed by this, it
> should be safe to simply revert the patch for 2.6.20.

The most important fix was:

Index: linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
===================================================================
--- linux-2.6.19.orig/arch/i386/kernel/cpu/cyrix.c
+++ linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
@@ -173,6 +173,7 @@ static void __cpuinit geode_configure(vo
 	ccr4 = getCx86(CX86_CCR4);
 	ccr4 |= 0x38;		/* FPU fast, DTE cache, Mem bypass */

+	setCx86(CX86_CCR4, ccr4);
 	setCx86(CX86_CCR3, ccr3);

 	set_cx86_memwb();

to write back the modified register content. But yes, it works also without 
this fix (but faster with it).

Juergen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/