linux-kernel - Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Feb 2007 06:07:50 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	"Michael K. Edwards" <medwards.linux@...il.com>,
	Linux Kernel List <linux-kernel@...r.kernel.org>
Subject: Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32)
 __iomem *addr?

H. Peter Anvin wrote:
> Jeff Garzik wrote:
>> Volatile is usually reserved for a specific need on a specific arch.  
>> I doubt it is correct to force it on all arches.
> 
> They already are volatile; the issue is adding "const".
> 
> All io(read|write)* pointers are volatile, IIRC.

No, none are volatile, hence my comment.

> [jgarzik@...tzel linux-2.6]$ grep volatile lib/iomap.c include/asm-generic/iomap.h 
> [jgarzik@...tzel linux-2.6]$ 

Maybe you were thinking about writel() and friends, whose implementation 
(not prototype!) includes use of volatile.

Regards,

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/