linux-kernel - Re: [PATCH] NTFS: Rename apparently incorrect macro name "NTFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Feb 2007 11:14:04 +0000
From:	Anton Altaparmakov <aia21@....ac.uk>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, aia21@...tab.net
Subject: Re: [PATCH] NTFS: Rename apparently incorrect macro name
	"NTFS_DEBUG".

Forgot to say the most important bit:  Thanks for the catch!  (-:

Best regards,

	Anton

On Fri, 2007-02-02 at 11:10 +0000, Anton Altaparmakov wrote:
> Hi,
> 
> On Fri, 2007-02-02 at 05:46 -0500, Robert P. J. Day wrote:
> >   Replace the apparently incorrect macro name "NTFS_DEBUG" with
> > "CONFIG_NTFS_DEBUG".
> > 
> > Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> > 
> > ---
> > 
> > diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> > index c577d8e..2154d03 100644
> > --- a/fs/ntfs/attrib.c
> > +++ b/fs/ntfs/attrib.c
> > @@ -1921,7 +1921,7 @@ s64 ntfs_attr_extend_allocation(ntfs_inode *ni, s64 new_alloc_size,
> >  	u32 attr_len = 0; /* Silence stupid gcc warning. */
> >  	bool mp_rebuilt;
> > 
> > -#ifdef NTFS_DEBUG
> > +#ifdef CONFIG_NTFS_DEBUG
> 
> The fix is also wrong.  It should be:
> 
> #ifdef DEBUG
> 
> See fs/ntfs/Makefile for details...
> 
> >  	read_lock_irqsave(&ni->size_lock, flags);
> >  	allocated_size = ni->allocated_size;
> >  	read_unlock_irqrestore(&ni->size_lock, flags);
> 
> Best regards,
> 
>         Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/