linux-kernel - Re: 2.6.20-rc6-mm3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Feb 2007 15:08:58 +1100
From:	David Chinner <dgc@....com>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...l.org>, David Chinner <dgc@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.20-rc6-mm3

On Thu, Feb 01, 2007 at 08:18:57PM +0100, Jens Axboe wrote:
> That down() probably wants a replug to precede it. Probably something
> like:
> 
>         if (atomic_read(&bp->b_io_remaining))
>                 blk_replug_current_nested();
> 
> for xfs_buf_wait_unpin() and xfs_buf_lock(). Does this fix it?

Jens, this patch looks like you originally removed the explicit
unplug calls that XFS used to prevent metadata I/O hangs and now you
are putting them back.  Correct?

Reading on from Andrew's earlier comments, shouldn't XFS have
worked unchanged? I'm just trying to understand why you removed
the explicit unplugs in the first place.....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/