linux-kernel - Re: 2.6.20-rc7: known regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702031151.17220.ak@suse.de>
Date:	Sat, 3 Feb 2007 11:51:16 +0100
From:	Andi Kleen <ak@...e.de>
To:	Frédéric Riss <frederic.riss@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Matt Domsch <Matt_Domsch@...l.com>,
	Adrian Bunk <bunk@...sta.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Eric Van Hensbergen <ericvh@...il.com>,
	Trond Myklebust <trond.myklebust@....uio.no>,
	Neil Brown <neilb@...e.de>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jeff Garzik <jeff@...zik.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Francois Romieu <romieu@...zoreil.com>
Subject: Re: 2.6.20-rc7: known regressions


> +#ifdef CONFIG_X86_32
> +#define efilinkage asmlinkage
> +#else
> +#define efilinkage
> +#endif

No ifdefs, this should be somewhere in the headers for the EFI supporting
architectures

But I suspect you could actually get away with just using asmlinkage
(after reviewing the ia64 asmlinkage I think it's ok)

x86-64 when it is ever implemented will always need asm stubs though
because it uses completely incompatible calling conventions.

> +
> +typedef efilinkage efi_status_t efi_get_time_t (efi_time_t *tm,
> +						efi_time_cap_t *tc);

I assume you have double checked it actually works? (i vaguely recall some
issues with applying attributes to typedefs). If not you would need
to put them to the declarations.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/