| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1170685227.11001.298.camel@quoit.chygwyn.com> Date: Mon, 05 Feb 2007 14:20:27 +0000 From: Steven Whitehouse <swhiteho@...hat.com> To: linux-kernel@...r.kernel.org Cc: cluster-devel@...hat.com Subject: [GFS2] Fix ordering of page disposal vs. glock_dq [14/54] >>From cb0d445259232c2ec717de827338e31650b7b07b Mon Sep 17 00:00:00 2001 From: Steven Whitehouse <swhiteho@...hat.com> Date: Mon, 8 Jan 2007 14:31:40 +0000 Subject: [PATCH] [GFS2] Fix ordering of page disposal vs. glock_dq In case of unlinked files with dirty pages GFS2 wasn't clearing the pages in quite the right order. This patch clears the pages earlier (before the qlock_dq) to avoid the situation that the release of the glock results in attempting to write back data that has already been deallocated. This fixes Red Hat bugzilla: #220117 Signed-off-by: Steven Whitehouse <swhiteho@...hat.com> diff --git a/fs/gfs2/ops_super.c b/fs/gfs2/ops_super.c index b283783..c22738c 100644 --- a/fs/gfs2/ops_super.c +++ b/fs/gfs2/ops_super.c @@ -429,6 +429,12 @@ static void gfs2_delete_inode(struct inode *inode) } error = gfs2_dinode_dealloc(ip); + /* + * Must do this before unlock to avoid trying to write back + * potentially dirty data now that inode no longer exists + * on disk. + */ + truncate_inode_pages(&inode->i_data, 0); out_unlock: gfs2_glock_dq(&ip->i_iopen_gh); -- 1.4.4.2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists