linux-kernel - [patch] MTD: fix DOC2000/2001/2001PLUS build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Feb 2007 09:45:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [patch] MTD: fix DOC2000/2001/2001PLUS build error


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> The half-time entertainment is provided by randomly inserted trivial 
> syntax errors that nerds are expected to fix at home before completing 
> the compile, but most people actually seem to mostly enjoy watching 
> the compile warnings, sponsored by Anheuser-Busch, scroll past.

i am honored to present the very first build fix for v2.6.20, as a
tribute to the Colts.

	Ingo

-------------------->
Subject: [patch] MTD: fix DOC2000/2001/2001PLUS build error
From: Ingo Molnar <mingo@...e.hu>

The very first "make ARCH=i386 randconfig" gave this build error:

    LD      vmlinux
  drivers/built-in.o: In function `cafe_nand_remove':
  cafe.c:(.text+0x19277a): undefined reference to `nand_release'
  drivers/built-in.o: In function `cafe_nand_cmdfunc':
  cafe.c:(.text+0x193036): undefined reference to `nand_wait_ready'
  drivers/built-in.o: In function `cafe_nand_probe':
  cafe.c:(.text+0x19359e): undefined reference to `nand_scan_ident'
  cafe.c:(.text+0x193658): undefined reference to `nand_scan_tail'
  distcc[1703] ERROR: compile (null) on localhost failed
  make: *** [vmlinux] Error 1

which i suspect was a side-effect of the late and optimistic MTD merge.

but hey, we always knew Linux was better at offense than at defense, and 
good offense is what wins the game in the end, as the Bears had to find 
out the hard way ;-)

so here's the fix for the 3 affected MTD drivers: DOC2000, DOC2001 and 
DOC2001PLUS.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 drivers/mtd/devices/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

Index: linux/drivers/mtd/devices/Kconfig
===================================================================
--- linux.orig/drivers/mtd/devices/Kconfig
+++ linux/drivers/mtd/devices/Kconfig
@@ -152,6 +152,7 @@ config MTD_DOC2000
 	tristate "M-Systems Disk-On-Chip 2000 and Millennium (DEPRECATED)"
 	depends on MTD
 	select MTD_DOCPROBE
+	select MTD_NAND
 	select MTD_NAND_IDS
 	---help---
 	  This provides an MTD device driver for the M-Systems DiskOnChip
@@ -175,6 +176,7 @@ config MTD_DOC2001
 	tristate "M-Systems Disk-On-Chip Millennium-only alternative driver (DEPRECATED)"
 	depends on MTD
 	select MTD_DOCPROBE
+	select MTD_NAND
 	select MTD_NAND_IDS
 	---help---
 	  This provides an alternative MTD device driver for the M-Systems
@@ -197,6 +199,7 @@ config MTD_DOC2001PLUS
 	tristate "M-Systems Disk-On-Chip Millennium Plus"
 	depends on MTD
 	select MTD_DOCPROBE
+	select MTD_NAND
 	select MTD_NAND_IDS
 	---help---
 	  This provides an MTD device driver for the M-Systems DiskOnChip
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/