linux-kernel - Re: [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Feb 2007 14:05:39 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	S?bastien Dugu? <sebastien.dugue@...l.net>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, linux-aio <linux-aio@...ck.org>,
	Bharata B Rao <bharata@...ibm.com>,
	Christoph Hellwig <hch@...radead.org>,
	Suparna Bhattacharya <suparna@...ibm.com>,
	Ulrich Drepper <drepper@...hat.com>,
	Zach Brown <zach.brown@...cle.com>,
	Badari Pulavarty <pbadari@...ibm.com>,
	Jean Pierre Dion <jean-pierre.dion@...l.net>
Subject: Re: [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups

On 02/06, S?bastien Dugu? wrote:
> 
> @@ -970,8 +969,14 @@ static long aio_setup_sigevent(struct ai
>  	rcu_read_lock();
>  	target = sigevent_find_task(&event);
>  
> -	if (unlikely(!target))
> +	if (unlikely(!target)) {
> +		/*
> +		 * Revert notify to SIGEV_NONE so that really_put_req()
> +		 * knows that no ref has been taken on a task.
> +		 */
> +		notify->notify = SIGEV_NONE;
>  		goto out_unlock;
> +	}

Very minor nit, feel free to ignore.

Isn't it better to move "notify->* = event.*;" down, when we know that
target != NULL. Imho, a bit easier to follow. This way we don't need to
reset notify->notify = SIGEV_NONE.

aio_setup_sigevent() relies on the fact that ->notify = SIGEV_NONE on
entry anyway.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/