linux-kernel - Re: [PATCH 2/11] Sched clock paravirt op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45C7FD6F.2070402@vmware.com>
Date:	Mon, 05 Feb 2007 20:00:47 -0800
From:	Zachary Amsden <zach@...are.com>
To:	Zachary Amsden <zach@...are.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Andi Kleen <ak@....de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH 2/11] Sched clock paravirt op

Zachary Amsden wrote:
>  
>  #include "mach_timer.h"
>  
> @@ -102,9 +103,6 @@ unsigned long long sched_clock(void)
>  {
>  	unsigned long long this_offset;
>  
> -	if (unlikely(custom_sched_clock))
> -		return (*custom_sched_clock)();
> -
>  	/*
>  	 * Fall back to jiffies if there's no TSC available:
>  	 */
> @@ -113,13 +111,13 @@ unsigned long long sched_clock(void)
>  		return (jiffies_64 - INITIAL_JIFFIES) * (1000000000 / HZ);
>  
>  	/* read the Time Stamp Counter: */
> -	rdtscll(this_offset);
> +	get_scheduled_cycles(this_offset);
>  
>  	/* return the value in ns */
>  	return cycles_2_ns(this_offset);
>  }
>   

I missed a title / signed-off on this guy.


Internally, sched_clock runs in units of nanoseconds, not CPU cycles.  
This was wrong in my previous patch.  Fix it so everyone can use the 
same cycles_2_ns code in tsc.c.

Signed-off-by: Zachary Amsden <zach@...are.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/