linux-kernel - Re: [PATCH][5/5] floppy.c: Fix device_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Feb 2007 00:59:13 -0500
From:	Gene Heskett <gene.heskett@...izon.net>
To:	linux-kernel@...r.kernel.org
Cc:	Jesper Juhl <jesper.juhl@...il.com>, Andi Kleen <ak@...e.de>,
	Trent Waddington <trent.waddington@...il.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

On Monday 05 February 2007 18:30, Jesper Juhl wrote:

And this is almost OT for this, but I'd like to interject here that in 
recent history, it has been very very difficult to properly access LSN0 
of a floppy.  Some formats, such as those laid down by a WD-1773 floppy 
controller, do indeed use a sector marking of '0' (zero) on all tracks.

This is akin to an old basic program that had a 'base' statement with an 
argument of zero or one.  We need, for legacy machines where a floppy 
disk sneakernet is in use, to maintain this "base 0" functionality in an 
easy to access format.  Ditto for sector sizes of 256 and even 128 bytes.

>This fixes the warning
>  warning: ignoring return value of `device_create_file', declared with
> attribute warn_unused_result in function `floppy_init'. It does this by
> checking the return value and printing a warning message in case of no
> success.
>
>
>Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
>---
>
> floppy.c |    7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>--- linux-2.6.20/drivers/block/floppy.c.patch4	2007-02-05
> 23:22:26.000000000 +0100 +++
> linux-2.6.20/drivers/block/floppy.c	2007-02-05 23:32:42.000000000 +0100
> @@ -4302,7 +4302,12 @@
> 		if (err)
> 			goto out_flush_work;
>
>-		device_create_file(&floppy_device[drive].dev,&dev_attr_cmos);
>+		err = device_create_file(&floppy_device[drive].dev, &dev_attr_cmos);
>+		if (err)
>+			printk(KERN_WARNING "Unable to create sysfs attribute "
>+				"file for floppy device: %s\n",
>+				floppy_device[drive].name);
>+
> 		/* to be cleaned up... */
> 		disks[drive]->private_data = (void *)(long)drive;
> 		disks[drive]->queue = floppy_queue;
>
>
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
Yahoo.com and AOL/TW attorneys please note, additions to the above
message by Gene Heskett are:
Copyright 2007 by Maurice Eugene Heskett, all rights reserved.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/