[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <45C997F1.9060102@qumranet.com>
Date: Wed, 07 Feb 2007 11:12:17 +0200
From: Avi Kivity <avi@...ranet.com>
To: Ingo Molnar <mingo@...e.hu>
CC: Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [patch] KVM, hotplug: export register_cpu_notifier
Ingo Molnar wrote:
> Subject: [patch] KVM, hotplug: export register_cpu_notifier
> From: Ingo Molnar <mingo@...e.hu>
>
> KVM-trunk uses register_cpu_notifier() but it's a module and we only
> export this if CONFIG_HOTPLUG_CPU. Export it otherwise too.
>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
> kernel/cpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/kernel/cpu.c
> ===================================================================
> --- linux.orig/kernel/cpu.c
> +++ linux/kernel/cpu.c
> @@ -75,10 +75,10 @@ int __cpuinit register_cpu_notifier(stru
> return ret;
> }
>
> -#ifdef CONFIG_HOTPLUG_CPU
> -
> EXPORT_SYMBOL(register_cpu_notifier);
>
> +#ifdef CONFIG_HOTPLUG_CPU
> +
> void unregister_cpu_notifier(struct notifier_block *nb)
> {
> mutex_lock(&cpu_add_remove_lock);
>
This is broken: register_cpu_notifier() is __cpuinit, which means it
disappears at module time if !CONFIG_CPU_HOTPLUG.
I submitted a hackaround to Andrew some time ago with the suspend patchset.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists