linux-kernel - Re: [patch 1/1] PM: Adds remount fs ro at suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702071510.13566.rjw@sisk.pl>
Date:	Wed, 7 Feb 2007 15:10:12 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Nigel Cunningham <nigel@...el.suspend2.net>,
	Andrew Morton <akpm@...ux-foundation.org>, akuster@...sta.com,
	linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>
Subject: Re: [patch 1/1] PM: Adds remount fs ro at suspend

On Wednesday, 7 February 2007 13:05, Henrique de Moraes Holschuh wrote:
> On Wed, 07 Feb 2007, Nigel Cunningham wrote:
> > > We don't cope okay with the power going out, at all.  And as an user case, a
> > > need for fsck if you do something that is a reasonable use case (unplugging
> > > devices while suspended) is not okay, either.
> > 
> > Maybe it depends on the filesystem you use. I've used ext3 for 6 or so
> > years of development on Suspend2, and it's never given me a single
> > problem, despite the fact that I've sometimes done the equivalent of
> > pulling the plug without a sync or unmount. I did try XFS at one stage.
> > It's performance was better, but it did give problems. Nevertheless, I'm
> > more than happy to make the above claim about ext3.
> 
> XFS comes to mind, indeed. But as I said, a need for fsck and unclean
> partitions are enough to label it as an "unsuitable" solution.
> 
> > > > Likewise with changes in hardware. Once hotplugging support is mature,
> > > > suspending, switching around hardware and resuming should just result in
> > > > hot[un]plug events.
> > > 
> > > Well, if we add *move* events for when someone unplugs a usb stick in one
> > > port and replugs it in another while the system is in lala-land... maybe :-)
> > > It would be normal to do it, when dealing with docks.
> > 
> > Isn't that part of the point to having those uuid thingys? I hate them
> > at the moment (from the point of view of suspend code), but hopefully
> > they'll end up being nicer to deal with.
> 
> When you have files open for writing (thus neither mount R/O or umount will
> suceed)?   No, you really need kernel support for this, and yes, I imagine
> it is a royal pain to deal with these cases, they clearly belong on the "20%
> of stuff that causes 80% of the work" side :-)

However, there are devices that don't need such handling.  This means there is
a clear distinction between the devices (or filesystems) that are not going to
"move" at run time or when the machine is suspended (think PATA hard disks)
and the devices that can be "moved".

IMO the userland should be able to tell the kernel "this filesystem is movable"
to indicate that it needs special handling during the suspend etc., but none of
the existing filesystems implements something like that AFAICS.

Alternatively, if freeze_bdev() is made available to the userland somehow,
we could be able to handle the "removable filesystems" from the userland too.

Greetings,
Rafael


-- 
If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/