[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0702071529390.14457@scrub.home>
Date: Wed, 7 Feb 2007 15:36:47 +0100 (CET)
From: Roman Zippel <zippel@...ux-m68k.org>
To: Oleg Verych <olecom@...wer.upol.cz>
cc: LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Jesper Juhl <jesper.juhl@...il.com>,
Sam Ravnborg <sam@...nborg.org>,
Horst Schirmeier <horst@...irmeier.com>,
Jan Beulich <jbeulich@...ell.com>,
Daniel Drake <dsd@...too.org>, Andi Kleen <ak@...e.de>,
Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: [patch 2/3, resend] kbuild: improve option checking, Kbuild.include
cleanup
Hi,
On Tue, 6 Feb 2007, Oleg Verych wrote:
> -- all checks by shell united in one macro -- checker-shell;
> -- one disposable output sym. link to /dev/null per shell,
> thus no racing, `-Z' is removed;
> -- modules' build output directory is used, if supplied;
> -- every option checking function calls shell wrapper, acquires probe;
> -- `echo -e' bashizm substituted (people with sh != bash have distinct
> CC options!);
> -- some spelling and sense added to the comments;
> -- small shuffle of whitespace.
This patch is a bit overloaded and it would be better to split it up to
keep functional changes separate and then please drop the symlink, it has
no advantage to a simple temp file.
Also please don't add random whitespace, Makefiles are no C files, so
different rules apply.
bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists