linux-kernel - Re: [PATCH 5/11] Fix PIT override bug for paravirt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45C92348.7090201@vmware.com>
Date:	Tue, 06 Feb 2007 16:54:32 -0800
From:	Zachary Amsden <zach@...are.com>
To:	Andi Kleen <ak@....de>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH 5/11] Fix PIT override bug for paravirt

Andi Kleen wrote:
> On Mon, Feb 05, 2007 at 07:53:02PM -0800, Zachary Amsden wrote:
>   
>> The time initialization changed for i386 when some code moved into time_init.
>> This made it no longer possible to override the PIT / HPET, which broke
>> paravirt guests.
>>     
>
> Looks still fragile. Can this be done cleaner? 
>
> In particularly some comments would be good, but clearer code 
> logic would be preferred.
>
> -Andi
>   

Well, the logic is still overly complicated, but I axed the ifdef and 
commented it.  It is difficult to work around the number of different 
compile and boot sequences here.

View attachment "pit-override" of type "text/plain" (2092 bytes)