linux-kernel - Re: [PATCH] pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702072138.03167.m.kozlowski@tuxland.pl>
Date:	Wed, 7 Feb 2007 21:38:02 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Alan <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org, jeff@...zik.org
Subject: Re: [PATCH] pata_acpi: take two

Hello,

	Just asking ... in:

> +static void *ata_pata_find_handle(struct device *dev, int port)

...

> +       chan_handle = acpi_get_child(handle, port);
> +       if (chan_handle == NULL)
> +               return NULL;
> +       return chan_handle;
> +}

why not simply:

	return acpi_get_child(hadnle, port);

?

Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/