linux-kernel - Re: [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a8748490702070058rab5a9d6vd57cf49b722e4850@mail.gmail.com>
Date:	Wed, 7 Feb 2007 09:58:12 +0100
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Oleg Verych" <olecom@...wer.upol.cz>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Roman Zippel" <zippel@...ux-m68k.org>,
	"Sam Ravnborg" <sam@...nborg.org>,
	"William Stearns" <wstearns@...ox.com>,
	"Martin Schlemmer" <azarah@...feratu.za.org>
Subject: Re: [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update

On 06/02/07, Oleg Verych <olecom@...wer.upol.cz> wrote:
> scripts: replace gawk, head, bc with shell, update
>
>   Replacing overhead of using some (external) programs
>   instead of good old `sh'.
>
> Cc: Roman Zippel <zippel@...ux-m68k.org>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: William Stearns <wstearns@...ox.com>
> Cc: Martin Schlemmer <azarah@...feratu.za.org>
> Signed-off-by: Oleg Verych <olecom@...wer.upol.cz>
> ---
>
>  Whitespace cleanup included.
>
>  scripts/gen_initramfs_list.sh | 43 +++++++++++++++++++++---------------------
>  scripts/makelst               | 34 ++++++++++++++++-----------------
>  2 files changed, 39 insertions(+), 38 deletions(-)
>
> Index: linux-2.6.20/scripts/makelst
> ===================================================================
> --- linux-2.6.20.orig/scripts/makelst   2007-02-06 02:12:38.811908000 +0100
> +++ linux-2.6.20/scripts/makelst        2007-02-06 02:12:43.688212750 +0100
> @@ -1,31 +1,31 @@
> -#!/bin/bash
> +#!/bin/sh

I don't like this change much.  We don't know what shell /bin/sh is on
a random users system - much better to be explicit and make sure we
use/require bash.
I expect this change to cause pain for users who have zsh, csh, ksh,
ash or some other shell as /bin/sh but also have /bin/bash available.
Previously things would just work, but now it will possibly break due
to using a different shell.

-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/