linux-kernel - Re: 2.6.20 BUG: soft lockup detected on CPU#0!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070208095612.GA9977@elte.hu>
Date:	Thu, 8 Feb 2007 10:56:12 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Lukasz Trabinski <lukasz@...siz.edu.pl>,
	linux-kernel@...r.kernel.org,
	Bartlomiej Solarz-Niesluchowski <solarz@...siz.edu.pl>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: 2.6.20 BUG: soft lockup detected on CPU#0!


* Eric Dumazet <dada1@...mosbay.com> wrote:

> This reminds me the current problem in close_files()
>  code, where we trigger soft lockup quite regularly.
> 
> Is there any chance/interest we can solve the issue Andrew had with 
> this patch ?
> 
> http://lkml.org/lkml/2006/5/2/273

yes - the -rt patch included the patch below for more than 2 years. 
(note that this one is even more finegrained)

	Ingo

Index: linux/kernel/exit.c
===================================================================
--- linux.orig/kernel/exit.c
+++ linux/kernel/exit.c
@@ -431,8 +433,10 @@ static void close_files(struct files_str
 		while (set) {
 			if (set & 1) {
 				struct file * file = xchg(&fdt->fd[i], NULL);
-				if (file)
+				if (file) {
 					filp_close(file, files);
+					cond_resched();
+				}
 			}
 			i++;
 			set >>= 1;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/