linux-kernel - Re: Kbuild change breaks the ppc64 build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070208.040003.112623191.davem@davemloft.net>
Date:	Thu, 08 Feb 2007 04:00:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	paulus@...ba.org
Cc:	olecom@...wer.upol.cz, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: Kbuild change breaks the ppc64 build

From: Paul Mackerras <paulus@...ba.org>
Date: Thu, 8 Feb 2007 22:10:54 +1100

> Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on
> 64-bit powerpc because we no longer get the -m64 flag passed to gcc.
> There is code in arch/powerpc/Makefile which adds (or used to add)
> -m64 to AS, LD and CC if we are running on a 64-bit machine (which I
> am) and have a biarch toolchain (which I do).  Without -m64, the
> toolchain assumes 32-bit and all sorts of things break spectacularly.
> 
> I haven't yet tracked down exactly why this commit has this effect,
> since I find it takes considerable time and effort to understand
> Kbuild.

It's this commit:

commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7
Author: Oleg Verych <olecom@...wer.upol.cz>
Date:   Tue Feb 6 02:18:21 2007 +0100

    [PATCH] kbuild: improve option checking, Kbuild.include cleanup
    
     GNU binutils, root users, tmpfiles, external modules ro builds must
     be fixed to do the right thing now.
    
    Cc: Roman Zippel <zippel@...ux-m68k.org>
    Cc: Sam Ravnborg <sam@...nborg.org>
    Cc: Horst Schirmeier <horst@...irmeier.com>
    Cc: Jan Beulich <jbeulich@...ell.com>
    Cc: Daniel Drake <dsd@...too.org>
    Cc: Andi Kleen <ak@...e.de>
    Cc: Randy Dunlap <randy.dunlap@...cle.com>
    Signed-off-by: Oleg Verych <olecom@...wer.upol.cz>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

Linus and Oleg tried to fix it with various subsequent changes
to scripts/Kbuild.include, but it's still broken.

For some reason $(call ...) invocations add spaces.  I tried
another test case:

define test
 $(shell echo -n)
endef

VAR:=$(call test)

all:
	@echo "\'$(VAR)\'"

And this always prints:

' TEST'

even with GNU Make version 3.81

If I put a $(strip ...) around the define, the space is
still there.  If I put the $(strip ...) around VAR's
$(call), the space goes away.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/