linux-kernel - Re: [PATCH] wrong order of kzalloc arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 Feb 2007 09:48:10 -0800
From:	"Kristen Accardi" <kristen.kml@...il.com>
To:	"Al Viro" <viro@....linux.org.uk>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wrong order of kzalloc arguments

On 2/9/07, Al Viro <viro@....linux.org.uk> wrote:
>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  drivers/acpi/bay.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
> index 667fa1d..91082ce 100644
> --- a/drivers/acpi/bay.c
> +++ b/drivers/acpi/bay.c
> @@ -296,7 +296,7 @@ static int bay_add(acpi_handle handle, int id)
>         /*
>          * Initialize bay device structure
>          */
> -       new_bay = kzalloc(GFP_ATOMIC, sizeof(*new_bay));
> +       new_bay = kzalloc(sizeof(*new_bay), GFP_ATOMIC);
>         INIT_LIST_HEAD(&new_bay->list);
>         new_bay->handle = handle;
>         new_bay->name = (char *)nbuffer.pointer;
> --
> 1.5.0-rc2.GIT
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Oops.  thanks for taking the time to review and fix this.

Kristen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/