linux-kernel - Re: [PATCH 2/2] Char: timers cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070209200108.GA2510@infomag.infomag.iguana.be>
Date:	Fri, 9 Feb 2007 21:01:08 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	R.E.Wolff@...Wizard.nl, jrv@...zandt.mv.com, alex@...uxhacker.org,
	support.linux@...ikey.com, a.zummo@...ertech.it,
	tpmdd_devel@...ts.sourceforge.net, steve@...aho.co.uk,
	hero@....uni-duisburg.de, fuganti@...ectiva.com.br, gorgo@....hu,
	khollis@...gate.com, lethal@...ux-sh.org
Subject: Re: [PATCH 2/2] Char: timers cleanup

Hi Jiri,

> timers cleanup
> 
> - Use timer macros to set function and data members and to modify
>   expiration time.
> - Use DEFINE_TIMER for global timers and do not init them at run-time in
>   these cases.
> - del_timer_sync is common in most cases -- we want to wait for timer
>   function if it's still running.

For the watchdog drivers: the timers are only used if the watchdog is active.
Why should we not init them at run time but use the DEFINE_TIMER macro?
Personnaly I prefer to use the same syntax in all the watchdog drivers
(thus either DEFINE_TIMER or either setup_timer() ).

Greetings,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/